Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps in garden : ign-gazebo7 #52

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Bumps in garden : ign-gazebo7 #52

merged 1 commit into from
Nov 11, 2021

Conversation

scpeters
Copy link
Contributor

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@chapulina chapulina merged commit 6922033 into master Nov 11, 2021
@chapulina chapulina deleted the bump_garden_ign-gazebo7 branch November 11, 2021 05:22
@Blast545
Copy link

👨‍🌾 There's a problem introduced with this PR. ign-gazebo jobs are failing now because this jobs gets ign-rendering@main, that is ign-rendering7 while ign-gazebo@main seems to be requiring ign-gazebo6.
See ign-gazebo@main/CMakeLists.txt#L138.

Reference failing job: https://build.osrfoundation.org/job/ign_gazebo-pr-win/3404

Should this issue be fixed modifying this job or opening a PR for ign-gazebo? @chapulina @scpeters PTAL

@scpeters
Copy link
Contributor Author

Bumping dependency versions is challenging since it leads to breakage with our current CI setup. Things should be unbroken once gazebosim/gz-sim#1183 is merged. If this is affecting open pull requests, we can revert this for now and merge it closer to when gazebosim/gz-sim#1183 is ready for testing

@chapulina
Copy link
Contributor

Yeah sorry I merged this too quickly and forgot that Windows uses it. I think it's ok to be in a broken state on some main branches until gazebo-tooling/release-tools#545 is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants