Add ci_matching_branch/ for bottle install jobs #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the release-tools branch (RTOOLS_BRANCH) starts with ci_matching_branch/ then try to check out a matching branch from the osrf/homebrew-simulation tap for bottle install jobs. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
This was referenced Sep 5, 2023
j-rivero
approved these changes
Nov 2, 2023
| @@ -46,6 +46,17 @@ echo '# BEGIN SECTION: setup the osrf/simulation tap' | |||
| brew tap osrf/simulation | |||
| echo '# END SECTION' | |||
|
|
|||
| if [[ -n "${RTOOLS_BRANCH}" ]] && \ | |||
There was a problem hiding this comment.
I'm quite sure that if RTOOLS_BRANCH is empty, the CI build are going to fail sooner than reaching this point. Leave it if you prefer to keep it anyway.
Signed-off-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
I've applied your linting suggestions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have started documenting how to use the
ci_matching_branch/naming pattern to use custom branches from tooling repositories in pull request CI in gazebosim/docs#377. This PR will add theci_matching_branch/functionality to theinstall_bottlejobs in the following way:RTOOLS_BRANCH) for aninstall_bottlejob starts withci_matching_branch/, then it will try to check out a matching branch from theosrf/homebrew-simulationtap.As an example for when this could be used, I'd like to re-enable a test for the
gz-sim7formula that has been disabled for macOS Monterey since a fix in gazebosim/gz-physics#529 has been merged and released. The test is enabled in osrf/homebrew-simulation@2bf74ac in theci_matching_branch/install_bottlebranch (which matches the branch name of this release-tools pull request) and tested in the following job, which happened to run on mac-five.monterey and passed the enabled test: