Fix -source jobs to deal with packages with underscores (i.e gz-fuel_tools) #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PACKAGEparameter in -source jobs is being populated by the args ofrelease.pyusing always hyphens even if theprojectname in CMakeLists.txt of the package (and thus the tarball generated) is using underscores. Some other parts of the infrastructure also applies this same naming.This is making the gz-fuel-tools -source package to fail since the -source jobs check for existence of
{canonical_package_name}-\${VERSION}.tar.*tarball. This PR relax that restriction and make a second pass to just*-\${VERSION}.tar.*to grab this exception.Tested: