Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gz-rendering9+: build without -DSKIP_optix #1161

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Conversation

scpeters
Copy link
Contributor

This was added in #456, but now it seems to be causing a cmake warning for an unused manually specified variable:

CMake Warning:
  Manually-specified variables were not used by the project:

    SKIP_optix

testing with this branch:

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Contributor Author

never mind, this introduces a cmake warning for ign-rendering3

@scpeters
Copy link
Contributor Author

oh, the cmake warning was introduced by gazebosim/gz-rendering#1032; I'll focus my attention there

@scpeters scpeters closed this Aug 14, 2024
@scpeters scpeters deleted the scpeters/no_skip_optix branch August 14, 2024 16:29
@scpeters scpeters restored the scpeters/no_skip_optix branch August 14, 2024 16:30
@scpeters
Copy link
Contributor Author

actually, let me add some version logic to this

@scpeters scpeters reopened this Aug 14, 2024
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Contributor Author

cmake warnings look fixed with the version logic added in

@scpeters scpeters changed the title gz-rendering: build without -DSKIP_optix gz-rendering9+: build without -DSKIP_optix Aug 14, 2024
@scpeters scpeters merged commit 19594d6 into master Aug 14, 2024
@scpeters scpeters deleted the scpeters/no_skip_optix branch August 14, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants