Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew supported distros: replace monterey with sonoma #1183

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

scpeters
Copy link
Contributor

Homebrew has already stopped supporting monterey as of Homebrew/brew#18314.

With this change, any bottle builds will only attempt to build bottles for ventura, until we add CI machines with a newer OS version.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters changed the title brew supported distro list: remove monterey brew supported distros: replace monterey with sonoma Sep 20, 2024
@scpeters
Copy link
Contributor Author

updated to add sonoma, now that we have a sonoma machine in the buildfarm

@scpeters
Copy link
Contributor Author

@scpeters
Copy link
Contributor Author

Sonoma bottles work!

@j-rivero j-rivero merged commit 7427202 into master Sep 23, 2024
1 check passed
@j-rivero j-rivero deleted the scpeters/brew_no_monterey branch September 23, 2024 09:44
@j-rivero
Copy link
Contributor

Amazing! Calling the generation of all DSL after the merge in Build Status.

@Crola1702 note that this will change the jobs names

@Crola1702
Copy link
Contributor

@Crola1702 note that this will change the jobs names

We still need to re-generate generated_jobs.txt, right?

@scpeters
Copy link
Contributor Author

I don't think this changes any job names; the generic-release-homebrew_triggered_bottle_builder job keeps its name but it has job configurations whose names change. I don't think those are listed in generated_jobs.txt though

@j-rivero
Copy link
Contributor

I don't think this changes any job names; the generic-release-homebrew_triggered_bottle_builder job keeps its name but it has job configurations whose names change. I don't think those are listed in generated_jobs.txt though

Ouch, Steve is right, we don't have anything named with the MacOSX versions in the buildfarm. Sorry @Crola1702 , you probably don't need to update anything at this point.

@Crola1702
Copy link
Contributor

Ouch, Steve is right, we don't have anything named with the MacOSX versions in the buildfarm. Sorry @Crola1702 , you probably don't need to update anything at this point.

Okay. Thanks. I won't have to do any changes also because we have an action that does that for us 😶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants