Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CRON_HOURLY string #966

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Fix CRON_HOURLY string #966

merged 1 commit into from
Jul 3, 2023

Conversation

Crola1702
Copy link
Contributor

CRON_HOURLY was unintentionally defined to run every minute in #962

After #965 it was, again, unintentionally defined to run every day instead of every hour.

This PR corrects this problem by making sure it runs every hour using the correct syntax.

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Third time lucky.

@@ -11,7 +11,7 @@ class Globals
static gazebodistro_branch = false

static CRON_EVERY_THREE_DAYS = 'H H * * H/3'
static CRON_HOURLY = 'H H * * *'
static CRON_HOURLY = 'H * * * *'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This string will run at an arbitrary minute of the hour H, of any hour of the day, any day of the month, any month of the year, any day of the week.

@Crola1702 Crola1702 merged commit 9f1096f into master Jul 3, 2023
1 check passed
@Crola1702 Crola1702 deleted the fix-outdated-job-cron-trigger branch July 3, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants