Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert display detection #978

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Revert display detection #978

merged 1 commit into from
Jul 31, 2023

Conversation

Crola1702
Copy link
Contributor

@Crola1702 Crola1702 commented Jul 31, 2023 •
edited
Loading

Currently, #916 is not detecting display in Linux agents.

Some Linux gazebo builds are showing display problems:

Log output: 
-- Looking for display capabilities
--  ! valid display not found
--  ! valid dri display not found (no glxinfo or pyopengl)

then:

65: qt.qpa.xcb: could not connect to display unix::0

or

11: [Err] [OgreRenderEngine.cc:358] Unable to open display: unix::0

Depending on the job.

Refer to #979 for more information

@Crola1702
Revert display detection
5a8be9a 
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
@Crola1702 Crola1702 requested a review from j-rivero as a code owner July 31, 2023 16:46
@Crola1702 Crola1702 mentioned this pull request Jul 31, 2023
Closed
@Crola1702 Crola1702 merged commit 45cf243 into master Jul 31, 2023
1 check passed
@Crola1702 Crola1702 deleted the Crola1702/revert-display-detection branch July 31, 2023 17:01
j-rivero added a commit that referenced this pull request Aug 1, 2023
@j-rivero
Revert "Revert: Robust display detection (#916) (#978)"
cc2adc3 
This reverts commit 45cf243.
j-rivero added a commit that referenced this pull request Aug 1, 2023
@j-rivero
Resurrect "Robust display detection" with a variable fix (#980)
554864a 
* Resurrect changes in (#916) (#978)
* Remove extra : in DISPLAY variable

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero j-rivero mentioned this pull request Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

@j-rivero j-rivero Awaiting requested review from j-rivero j-rivero is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Crola1702 @nuclearsandwich