Skip to content

Commit

Permalink
remove mention of issue #624 and the temporary fix
Browse files Browse the repository at this point in the history
  • Loading branch information
John Hsu committed Jan 7, 2014
1 parent c2a6c2c commit e75cdf6
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions gazebo/physics/ode/ODEPhysics.cc
Original file line number Diff line number Diff line change
Expand Up @@ -894,10 +894,7 @@ void ODEPhysics::Collide(ODECollision *_collision1, ODECollision *_collision2,
if (fd != math::Vector3::Zero)
{
// fdir1 is in body local frame, rotate it into world frame
/// \TODO: once issue #624 is fixed, switch to below:
/// fd = _collision1->GetWorldPose().rot.RotateVector(fd);
fd = (_collision1->GetRelativePose() +
_collision1->GetLink()->GetWorldPose()).rot.RotateVector(fd.Normalize());
fd = _collision1->GetWorldPose().rot.RotateVector(fd);
}

/// \TODO: Better treatment when both surfaces have fdir1 specified.
Expand All @@ -912,10 +909,8 @@ void ODEPhysics::Collide(ODECollision *_collision1, ODECollision *_collision2,
_collision1->GetSurface()->mu1 > _collision2->GetSurface()->mu1))
{
// fdir1 is in body local frame, rotate it into world frame
/// \TODO: once issue #624 is fixed, switch to below:
/// fd2 = _collision2->GetWorldPose().rot.RotateVector(fd2);
fd = (_collision2->GetRelativePose() +
_collision2->GetLink()->GetWorldPose()).rot.RotateVector(fd2.Normalize());
fd2 = _collision2->GetWorldPose().rot.RotateVector(fd2);

/// \TODO: uncomment gzlog below once we confirm it does not affect
/// performance
/// if (fd2 != math::Vector3::Zero && fd != math::Vector3::Zero &&
Expand Down

0 comments on commit e75cdf6

Please sign in to comment.