Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include IMAGE_PATH directories in ign_create_docs #183

Merged
merged 4 commits into from
Aug 26, 2021
Merged

Include IMAGE_PATH directories in ign_create_docs #183

merged 4 commits into from
Aug 26, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 25, 2021

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

I was playing a little bit with the doxygen warning and I noticed that IMAGE_PATH is not included as an argument in the function ign_create_docs

Checklist

  • Signed all commits for DCO
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@ahcorde
Include IMAGE_PATH directories in ign_create_docs
abcc91c 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from adlarkin August 25, 2021 16:36
@ahcorde ahcorde self-assigned this Aug 25, 2021
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Aug 25, 2021
@ahcorde ahcorde mentioned this pull request Aug 25, 2021
Merged
7 tasks
adlarkin
adlarkin reviewed Aug 25, 2021
View reviewed changes
Copy link
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look okay to me. You mentioned you were looking at the warnings - where would the warning for this be located in a colcon workspace? I am trying to test this locally.

cmake/IgnCreateDocs.cmake Outdated Show resolved Hide resolved
@ahcorde
style
dfb9f23 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Merge branch 'ahcorde/image_path' of https://github.com/ignitionrobot…
422d492 
…ics/ign-cmake into ahcorde/image_path
@ahcorde ahcorde requested a review from adlarkin August 25, 2021 19:01
@ahcorde ahcorde merged commit c378cb5 into ign-cmake2 Aug 26, 2021
@ahcorde ahcorde deleted the ahcorde/image_path branch August 26, 2021 07:19
@ahcorde ahcorde mentioned this pull request Aug 26, 2021
Merged
5 tasks
srmainwaring pushed a commit to srmainwaring/gz-cmake that referenced this pull request Mar 1, 2022
@ahcorde @adlarkin @srmainwaring
Include IMAGE_PATH directories in ign_create_docs (gazebosim#183)
aca4ab6 
* Include IMAGE_PATH directories in ign_create_docs

Signed-off-by: ahcorde <ahcorde@gmail.com>

* style

Signed-off-by: ahcorde <ahcorde@gmail.com>

Co-authored-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
@azeey azeey mentioned this pull request Oct 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlarkin adlarkin adlarkin approved these changes

@j-rivero j-rivero Awaiting requested review from j-rivero j-rivero is a code owner

@mxgrey mxgrey Awaiting requested review from mxgrey

Assignees

@ahcorde ahcorde

Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahcorde @adlarkin