Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace exec_program calls (not working out of the box in CMake 3.28) #409

Closed
wants to merge 1 commit into from

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented Feb 2, 2024

🦟 Bug fix

Summary

exec_program calls start to fail unless a given policy is set in CMake starting with Cmake 3.28 (the version in Noble). Replace the existing calls.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Feb 2, 2024
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made similar changes in #402. I should have backported it. I think the way RESULT_VARIABLE is handled was a little tricky. Have you tried running make uninstall?

@j-rivero
Copy link
Contributor Author

j-rivero commented Feb 2, 2024

I made similar changes in #402. I should have backported it.

Oh I missed it.

I think the way RESULT_VARIABLE is handled was a little tricky. Have you tried running make uninstall?

I haven't. I was forwarding the changed made in Debian to ign-cmake2 by other user and only did a visual inspection but did not run any code. I'll take care of backporting #402

@j-rivero j-rivero closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants