Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows AV CI warnings and test failures #135

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

mjcarroll
Copy link
Contributor

I believe that these were introduced by changes in the Windows hosts, allowing the av component to be built and tested, so not necessarily a regression.

Signed-off-by: Michael Carroll michael@openrobotics.org

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Dec 4, 2020
@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #135 (c55e9ee) into ign-common3 (63f7e55) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-common3     #135   +/-   ##
============================================
  Coverage        75.38%   75.38%           
============================================
  Files               69       69           
  Lines             9488     9488           
============================================
  Hits              7153     7153           
  Misses            2335     2335           
Impacted Files Coverage Δ
av/src/VideoEncoder.cc 72.24% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63f7e55...c55e9ee. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that these were introduced by changes in the Windows hosts, allowing the av component to be built and tested

Totally! Nice! It looks like we can close #122 🎉

@chapulina chapulina merged commit 2b1c928 into ign-common3 Dec 4, 2020
@chapulina chapulina deleted the fix_windows_av branch December 4, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants