Collada transparency is opposite. #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nate Koenig <nate@openrobotics.org>
github-actions
bot
added
🏢 edifice
Codecov Report
@@ Coverage Diff @@
## ign-common3 #152 +/- ##
============================================
Coverage 75.53% 75.53%
============================================
Files 69 69
Lines 9623 9623
============================================
Hits 7269 7269
Misses 2354 2354
Continue to review full report at Codecov.
|
mjcarroll
approved these changes
Jan 20, 2021
azeey
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collada considers an object to be transparent when the
<transparent>value is 0 instead of 1.This resolves: gazebosim/gz-sim#474 (comment)
Signed-off-by: Nate Koenig nate@openrobotics.org