Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of #240 to fix memory leaks in Image. #287

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

peci1
Copy link
Contributor

@peci1 peci1 commented Jan 5, 2022

🦟 Bug fix

Fixes gazebosim/gz-gui#341 .

Summary

#240 contains a lot of fixes for Image, but was only merged to ign-common4. This PR backports it into 3.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Fixes ign-gui#341.

Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
@peci1 peci1 requested a review from mjcarroll as a code owner January 5, 2022 03:28
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Jan 5, 2022
@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #287 (926580a) into ign-common3 (6d6b9d5) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-common3     #287      +/-   ##
===============================================
+ Coverage        76.55%   76.58%   +0.02%     
===============================================
  Files               73       73              
  Lines            10387    10403      +16     
===============================================
+ Hits              7952     7967      +15     
- Misses            2435     2436       +1     
Impacted Files Coverage Δ
graphics/src/Image.cc 68.75% <100.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d6b9d5...926580a. Read the comment docs.

@ahcorde ahcorde merged commit af625e2 into gazebosim:ign-common3 Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants