Test that Delaunay triangles wind clockwise #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
8 tasks
iche033
approved these changes
Aug 15, 2024
iche033
added a commit
that referenced
this pull request
Aug 15, 2024
* Fix triangle dir, lint, style * update migration guide * Test that Delaunay triangles wind clockwise (#624) --------- Signed-off-by: Ian Chen <ichen@openrobotics.org> Signed-off-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Adds a test for #623
Summary
PR #623 ensures that Delaunay triangles have clockwise winding; this confirms that with a test using a cross product
(v2 - v1) x (v3 - v2). Since Z = 0 for all the vertices in this test, the cross product should have a negative Z component for clockwise winding (right-hand rule is positive for counter-clockwise, negative for clockwise).Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.