Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #632
Summary
The severity level of
gzlog
was incorrectly set toerr
. Changing this totrace
solves two problems:gz sim -v4
, this message is not shown on the console. It will only be logged to file. It does show up on the console if you run with-v5
.The second point is technically a behavior change since in Harmonic, regardless of the verbosity level,
gzlog
would never show up on the console. However, duplicating that behavior with the new Console implementation proved to be very complicated. So, I propose we change the meaning ofgzlog
to be equivalent togztrace
.Note
We'll have to make new prereleases of all downstream libraries for this fix to propagate. I vote we just wait for the stable release.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.