Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ubuntu 24.04 in Github Actions CI workflow #427

Merged
merged 5 commits into from
Aug 1, 2024
Merged

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Jul 19, 2024

This also enables codecov and linters.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from nkoenig as a code owner July 19, 2024 21:26
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Jul 19, 2024
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
scpeters added a commit that referenced this pull request Jul 20, 2024
add a .github/ci/dependencies.yaml to build
gz-* dependencies from source
@scpeters
Copy link
Member

I've attempted to test this branch against gazebosim/gz-cmake#436 in #428. The workflow passes, although there still seems like a problem with the codecov upload

@azeey azeey requested a review from scpeters July 22, 2024 18:39
@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 29, 2024
@scpeters
Copy link
Member

I've merged gazebosim/gz-cmake#436 and am rebuilding the nightly debs

@scpeters
Copy link
Member

I reran the workflow, and it passes, but codecov fails to upload with the following error:

{'detail': ErrorDetail(string='Missing "owner" argument. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}

also, merging gazebosim/gz-cmake#436 broke the Ionic workflows that are still using Jammy for coverage (see gazebosim/gz-utils#133)

@scpeters
Copy link
Member

also, merging gazebosim/gz-cmake#436 broke the Ionic workflows that are still using Jammy for coverage (see gazebosim/gz-utils#133)

reverted in gazebosim/gz-cmake#441

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey
Copy link
Contributor Author

azeey commented Jul 30, 2024

I've disabled codecov for now in 8933a58. It looks like we never enabled it for Harmonic either.

runs-on: ubuntu-latest
name: Ubuntu Jammy CI
name: Ubuntu Noble CI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of the other packages have added Noble CI alongside Jammy. Should we be disabling that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't have codecov working in Noble, perhaps we should leave Jammy in for now. Otherwise, I don't think there's a need to keep Jammy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added jammy back in 85e4178 with codecov enabled.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey merged commit e3f55e9 into main Aug 1, 2024
9 checks passed
@azeey azeey deleted the azeey/add_noble branch August 1, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants