Plotting Header time #115
Merged
Plotting Header time #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
chapulina
force-pushed
the
plotting-interface-time-tick
branch
from
4abc9df
to
994d255
Compare
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
…/AmrElsersy/ign-gui into plotting-interface-time-tick
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
chapulina
reviewed
Sep 1, 2020
There was a problem hiding this comment.
This is working for me both for topics that have a header and for those which don't. Good job, Amr! I have some small comments below.
I saw this warning, not sure what I did to trigger it:
[GUI] [Wrn] [Application.cc:649] [QT] qrc:/qml/PlottingInterface.qml:328:19: Unable to assign double to QSize
claireyywang
suggested changes
Sep 1, 2020
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
chapulina
suggested changes
Sep 2, 2020
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
chapulina
reviewed
Sep 3, 2020
chapulina
reviewed
Sep 3, 2020
|
This fixes the QML error for me, it's another one of those differences due to the javascript version: diff --git a/include/ignition/gui/qml/Chart.qml b/include/ignition/gui/qml/Chart.qml
index 5403df2..7f3b7cd 100644
--- a/include/ignition/gui/qml/Chart.qml
+++ b/include/ignition/gui/qml/Chart.qml
@@ -485,7 +485,7 @@ Rectangle {
add new series
ID key of the series: path of the field of the series
*/
- function addSeries(ID, seriesDisplayText = "") {
+ function addSeries(ID, seriesDisplayText) {
var seriesName = (seriesDisplayText) ? seriesDisplayText : ID
var newSeries = createSeries(ChartView.SeriesTypeLine, seriesName, xAxis, yAxis);
newSeries.useOpenGL = true; |
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
chapulina
approved these changes
Sep 5, 2020
There was a problem hiding this comment.
Works for me! And it works with gazebosim/gz-sim#270 as well. Great work! Let's wait for @claireyywang 's review.
Signed-off-by: Louise Poubel <louise@openrobotics.org>
claireyywang
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving Plotting performance
Plotting tool time update:
Plotting according to the time that is associated with the header field of the msg if exists
for example, plotting a topic with a header time = sim time, makes the plotting stops if the simulation stops
@chapulina @claireyywang