Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small tweaks to the plot plugin #125

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Small tweaks to the plot plugin #125

merged 1 commit into from
Sep 18, 2020

Conversation

chapulina
Copy link
Contributor

Just a couple of tweaks that I noticed while reviewing gazebosim/gz-sim#270:

  • The check in Chart.qml is needed to avoid warnings after a field is deleted from a plot
  • Changed the title of the transport plotting plugin so it's different from the one in ign-gazebo.

@AmrElsersy , mind taking a look?

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the beta Targeting beta release of upcoming collection label Sep 17, 2020
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Sep 17, 2020
@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #125 into master will increase coverage by 0.15%.
The diff coverage is 47.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   63.07%   63.23%   +0.15%     
==========================================
  Files          20       20              
  Lines        2592     2592              
==========================================
+ Hits         1635     1639       +4     
+ Misses        957      953       -4     
Impacted Files Coverage Δ
src/PlottingInterface.cc 56.52% <0.00%> (+0.80%) ⬆️
src/plugins/world_stats/WorldStats.cc 97.27% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03466fc...2515bf5. Read the comment docs.

Copy link
Contributor

@claireyywang claireyywang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chapulina chapulina merged commit 3a03905 into master Sep 18, 2020
@chapulina chapulina deleted the chapulina/plot_tweaks branch September 18, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants