Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable image.config test #140

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Conversation

chapulina
Copy link
Contributor

Resolves #40

I can't reproduce the test failure locally, hopefully it's working on CI as well, we'll see 🤞

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the tests Broken or missing tests / testing infra label Oct 17, 2020
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Oct 17, 2020
@chapulina chapulina linked an issue Oct 17, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 17, 2020

Codecov Report

Merging #140 into ign-gui3 will decrease coverage by 2.49%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gui3     #140      +/-   ##
============================================
- Coverage     62.06%   59.57%   -2.50%     
============================================
  Files            19       20       +1     
  Lines          2312     2471     +159     
============================================
+ Hits           1435     1472      +37     
- Misses          877      999     +122     
Impacted Files Coverage Δ
src/plugins/image_display/ImageDisplay.cc 23.27% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4434fb...d893ad1. Read the comment docs.

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there is a Windows failure but it's unrelated:

  Target "ignition-transport8-log" links to target "ZeroMQ::ZeroMQ" but the
  target was not found.  Perhaps a find_package() call is missing for an
  IMPORTED target, or an ALIAS target is missing?

@chapulina chapulina merged commit 60c1015 into ign-gui3 Oct 19, 2020
@chapulina chapulina deleted the chapulina/3/imageconfigtest branch October 19, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel tests Broken or missing tests / testing infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example image.config is broken
2 participants