Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Capsule and Ellipsoid in Scene3D #214

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Support Capsule and Ellipsoid in Scene3D #214

merged 1 commit into from
Apr 28, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Apr 28, 2021

Signed-off-by: ahcorde ahcorde@gmail.com

🦟 Bug fix

Summary

Capsule and ellipsoid are not handle in the Scene3D. These PR adds support for them

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@ahcorde ahcorde requested a review from chapulina April 28, 2021 18:48
@ahcorde ahcorde self-assigned this Apr 28, 2021
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Apr 28, 2021
@ahcorde
Support Capsule and Ellipsoid in Scene3D
14f6cd5 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde force-pushed the ahcorde/support_ellipsoid_capsule branch from 84f46d0 to 14f6cd5 Compare April 28, 2021 18:49
chapulina
chapulina approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💊

@chapulina chapulina merged commit 8f7a8a8 into ign-gui5 Apr 28, 2021
@chapulina chapulina deleted the ahcorde/support_ellipsoid_capsule branch April 28, 2021 22:57
@jennuine jennuine mentioned this pull request Apr 28, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees

@ahcorde ahcorde

Labels
🏢 edifice Ignition Edifice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahcorde @chapulina