Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved tape measure and grid config from ign-gazebo to ign-gui #236

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jun 21, 2021

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 Enhancement

Summary

Moved from ign-gazebo some plugins which are not gazebo specific to ign-gui

  • tape_measure
  • grid_config

Related with this issue gazebosim/gz-sim#835

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: ahcorde <ahcorde@gmail.com>
@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #236 (d3e734d) into main (090e290) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #236   +/-   ##
=======================================
  Coverage   58.16%   58.16%           
=======================================
  Files          24       24           
  Lines        3069     3069           
=======================================
  Hits         1785     1785           
  Misses       1284     1284           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 090e290...d3e734d. Read the comment docs.

@ahcorde
Copy link
Contributor Author

ahcorde commented Jun 21, 2021

@osrf-jenkins retest this please

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works perfectly with ign-gazebo, but I wasn't able to test properly with ign-gui's Scene3D because that's not updating well on my system right now. I wonder if it's some problem that has been recently fixed in ign-gazebo's scene.

@chapulina chapulina merged commit c85bffa into main Jun 22, 2021
@chapulina chapulina deleted the ahcorde/move_plugin_to_gui branch June 22, 2021 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants