Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove windows warnings in CameraTracking #254

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jul 16, 2021

Signed-off-by: ahcorde ahcorde@gmail.com

🦟 Bug fix

Fixes #255

Summary

Remove windows warnings in INTEGRATION_CameraTracking generated by pose.pb.h

Checklist

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the enhancement New feature or request label Jul 16, 2021
@ahcorde ahcorde self-assigned this Jul 16, 2021
@ahcorde ahcorde requested a review from jennuine as a code owner July 16, 2021 09:17
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jul 16, 2021
@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #254 (c882152) into main (bbad5be) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
+ Coverage   65.24%   65.29%   +0.05%     
==========================================
  Files          27       27              
  Lines        3979     3979              
==========================================
+ Hits         2596     2598       +2     
+ Misses       1383     1381       -2     
Impacted Files Coverage Δ
src/plugins/minimal_scene/MinimalScene.cc 52.15% <0.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbad5be...c882152. Read the comment docs.

@ahcorde
Copy link
Contributor Author

ahcorde commented Jul 16, 2021

@mjcarroll mjcarroll merged commit f107bd1 into main Jul 16, 2021
@mjcarroll mjcarroll deleted the ahcorde/windows_warnings/camera_tracking branch July 16, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants