Fixed Right click press position #284
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
chapulina
added
beta
| @@ -248,6 +248,8 @@ void IgnRenderer::BroadcastRightClick() | |||
|
|
|||
| events::RightClickToScene rightClickToSceneEvent(pos); | |||
| App()->sendEvent(App()->findChild<MainWindow *>(), &rightClickToSceneEvent); | |||
| events::RightClickOnScene rightClickOnSceneEvent(this->dataPtr->mouseEvent); | |||
| App()->sendEvent(App()->findChild<MainWindow *>(), &rightClickOnSceneEvent); | |||
There was a problem hiding this comment.
Should we do the same for the left click?
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah thanks. But it's strange that these are not done in the same place. The right click is in Broadcast while the left click is in HandleMouseViewControl. Do you know why they're not handled the same way?
There was a problem hiding this comment.
I think we can sort this out later, let's get this PR in
Codecov Report
@@ Coverage Diff @@
## main #284 +/- ##
==========================================
+ Coverage 65.20% 65.26% +0.06%
==========================================
Files 32 32
Lines 4532 4621 +89
==========================================
+ Hits 2955 3016 +61
- Misses 1577 1605 +28
Continue to review full report at Codecov.
|
Signed-off-by: ahcorde <ahcorde@gmail.com>
| @@ -248,6 +248,8 @@ void IgnRenderer::BroadcastRightClick() | |||
|
|
|||
| events::RightClickToScene rightClickToSceneEvent(pos); | |||
| App()->sendEvent(App()->findChild<MainWindow *>(), &rightClickToSceneEvent); | |||
| events::RightClickOnScene rightClickOnSceneEvent(this->dataPtr->mouseEvent); | |||
| App()->sendEvent(App()->findChild<MainWindow *>(), &rightClickOnSceneEvent); | |||
There was a problem hiding this comment.
I think we can sort this out later, let's get this PR in
Signed-off-by: ahcorde ahcorde@gmail.com
🦟 Bug fix
Summary
The right click press position is not being published.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge