-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort out MinimalScene's mouse events #295
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
This PR fixes:
I'm trying to debug -> Incorrect mouse anchor point. |
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
…s/ign-gui into chapulina/6/events Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## main #295 +/- ##
==========================================
+ Coverage 65.31% 65.42% +0.11%
==========================================
Files 32 32
Lines 4621 4686 +65
==========================================
+ Hits 3018 3066 +48
- Misses 1603 1620 +17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, some minor comments/questions
Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
🦟 Bug fix
Fixes #293
Summary
I started working on the issues pointed out on #293 and ran into various other issues and inconsistencies about the way we're handling mouse events. Currently there are scrolls and drags being sent as left clicks, both mouse presses and releases broadcasted as clicks...
I'm still sorting it out, hopefully will be done in time for the release.Summary of changes:
HandleMouseViewControl
was a confusing function that re-sent the left clicks, so I removed itChecklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸