Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added macOS source code installation instructions #297

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Oct 1, 2021

Signed-off-by: Alejandro Hernández ahcorde@gmail.com

🦟 Bug fix

Summary

Added macOS source code installation instructions

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Oct 1, 2021
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Oct 1, 2021
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #297 (3e7208c) into main (653b0fb) will increase coverage by 0.16%.
The diff coverage is 46.03%.

❗ Current head 3e7208c differs from pull request most recent head 25e0c4f. Consider uploading reports for the commit 25e0c4f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
+ Coverage   65.31%   65.47%   +0.16%     
==========================================
  Files          32       32              
  Lines        4621     4686      +65     
==========================================
+ Hits         3018     3068      +50     
- Misses       1603     1618      +15     
Impacted Files Coverage Δ
include/ignition/gui/GuiEvents.hh 100.00% <ø> (ø)
...interactive_view_control/InteractiveViewControl.cc 16.52% <10.71%> (+2.24%) ⬆️
src/plugins/minimal_scene/MinimalScene.cc 58.92% <32.75%> (-0.54%) ⬇️
src/Conversions.cc 95.00% <78.94%> (-5.00%) ⬇️
src/GuiEvents.cc 100.00% <100.00%> (ø)
src/plugins/scene3d/Scene3D.cc 49.09% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 653b0fb...25e0c4f. Read the comment docs.

Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I don't have a macOS system to test this. Also, should this target an earlier version or at least ign-gui5?

@chapulina chapulina merged commit 53360bb into main Oct 7, 2021
@chapulina chapulina deleted the ahcorde/macos/install branch October 7, 2021 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants