Fix message display in TopicEcho

[srmainwaring]

🦟 Bug fix

Summary

This PR fixes a problem with the TopicEcho plugin where the message is not displayed correctly.

This may be apparent on macOS because of the Qt version installed using homebrew (details below).

• Change the binding of the width property in ListView delegate (see: https://stackoverflow.com/questions/63767669/parent-is-null-in-listview-delegate-after-upgrade-to-qt-5-15)
• Use scoped references model.display (see: https://forum.qt.io/topic/92085/using-qstringlistmodel-as-model-in-listview)

System

OS: macOS Big Sur 11.6.4

Qt version: 5.15.2

$ brew info qt@5
qt@5: stable 5.15.2 (bottled) [keg-only]
Cross-platform application and UI framework
https://www.qt.io/
/usr/local/Cellar/qt@5/5.15.2_1 (10,688 files, 365.9MB)
  Poured from bottle on 2021-10-22 at 15:10:42
From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/qt@5.rb
License: GFDL-1.3-only and GPL-2.0-only and GPL-3.0-only and LGPL-2.1-only and LGPL-3.0-only
==> Dependencies
Build: pkg-config ✔
==> Requirements
Build: Xcode ✔
Required: macOS >= 10.12 ✔

Before

The messages are not displayed correctly and a warning is printed to the terminal.

$ ign gui -c examples/config/pubsub.config
...
[GUI] [Wrn] [Application.cc:698] [QT] file::/TopicEcho/TopicEcho.qml:105: TypeError: Cannot read property 'width' of null

After

The messages display as expected and there is no warning.

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

[ahcorde]

we should target ign-gui3, @chapulina ?

[chapulina]

Thanks for the fix, works for me. Would you be able to retarget the PR to ign-gui3 (Citadel), and then we'll merge forward? Thanks!

[srmainwaring]

Thanks for the fix, works for me. Would you be able to retarget the PR to ign-gui3 (Citadel)

I've changed the base branch to ign-gui3 and rebased the topic branch. Unfortunately it seems you can't change the topic branch in a PR so I'm stuck with the name.

retargeted

[codecov]

Codecov Report

Merging #322 (734b856) into ign-gui3 (8b3f2b0) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           ign-gui3     #322      +/-   ##
============================================
- Coverage     66.80%   66.73%   -0.07%     
============================================
  Files            25       25              
  Lines          2961     2961              
============================================
- Hits           1978     1976       -2     
- Misses          983      985       +2     

Impacted Files	Coverage Δ
src/plugins/scene3d/Scene3D.cc	42.11% <0.00%> (-0.28%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b3f2b0...734b856. Read the comment docs.

[osrf-triage]

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1

[osrf-triage]

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-24-citadel-edifice-fortress/1241/1

[osrf-triage]

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1