Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve KeyPublisher's usability #362

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Part of gazebosim/gz-sim#1254

Summary

A new user inserting the KeyPublisher plugin may get confused when they just see an empty plugin. With this PR, the plugin provides more information to the user:

keypublisher

This shouldn't affect use cases where the plugin is placed floating with a small size, like this.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the OOBE 📦✨ Out-of-box experience label Mar 3, 2022
@chapulina chapulina requested a review from jennuine as a code owner March 3, 2022 01:49
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Mar 3, 2022
@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #362 (467677c) into ign-gui3 (a6afb94) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           ign-gui3     #362   +/-   ##
=========================================
  Coverage     67.79%   67.79%           
=========================================
  Files            28       28           
  Lines          3118     3118           
=========================================
  Hits           2114     2114           
  Misses         1004     1004           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6afb94...467677c. Read the comment docs.

@chapulina chapulina merged commit fc2f870 into ign-gui3 Mar 3, 2022
@chapulina chapulina deleted the chapulina/3/keypub_ux branch March 3, 2022 19:06
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel OOBE 📦✨ Out-of-box experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants