-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TransportSceneManager: Prevent freeze when inserted from menu #365
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a small comment about the how to display the topic names
Signed-off-by: ahcorde <ahcorde@gmail.com> Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-gui6 #365 +/- ##
============================================
+ Coverage 65.39% 65.48% +0.09%
============================================
Files 39 39
Lines 5123 5148 +25
============================================
+ Hits 3350 3371 +21
- Misses 1773 1777 +4
Continue to review full report at Codecov.
|
🦟 Bug fix
Summary
Currently, the
TransportSceneManager
freezes the window when inserted from the GUI menu, because it's waiting for an empty transport service for 30 seconds. With this PR:Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸