Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix menu scrolling when a new plugin is added #368

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

Scrolling the right split has been broken since #194. It only took me a year to come back and fix it 🙃

There were 2 issues:

  • The scope when setting Layout.minimumWidth
  • The logic meant to check if an item is collapsed was using its current height, instead of its Layout.maximumHeight

I hope I'm not introducing yet another bug. I think all use cases mentioned in #194 are covered here, but I'd appreciate if the reviewers really try to break this.

split_scroll

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the OOBE 📦✨ Out-of-box experience label Mar 4, 2022
@chapulina chapulina requested a review from jennuine as a code owner March 4, 2022 22:24
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Mar 4, 2022
@chapulina chapulina linked an issue Mar 4, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #368 (c45bedf) into ign-gui3 (fc2f870) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           ign-gui3     #368   +/-   ##
=========================================
  Coverage     65.96%   65.96%           
=========================================
  Files            29       29           
  Lines          3191     3191           
=========================================
  Hits           2105     2105           
  Misses         1086     1086           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc2f870...c45bedf. Read the comment docs.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina enabled auto-merge (squash) March 7, 2022 17:38
@chapulina chapulina merged commit 755b995 into ign-gui3 Mar 7, 2022
@chapulina chapulina deleted the chapulina/3/split_scroll branch March 7, 2022 18:17
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel OOBE 📦✨ Out-of-box experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't scroll to newly added plugin
3 participants