Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bionic from future releases (Garden+) #371

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

chapulina
Copy link
Contributor

Summary

ign-gui7 will be on Garden.

Test it

No Bionic builds should be triggered.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added documentation Improvements or additions to documentation tests Broken or missing tests / testing infra labels Mar 11, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Mar 11, 2022
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #371 (185b936) into main (63b3599) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 185b936 differs from pull request most recent head d00cd15. Consider uploading reports for the commit d00cd15 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
- Coverage   63.84%   63.83%   -0.01%     
==========================================
  Files          45       45              
  Lines        5462     5459       -3     
==========================================
- Hits         3487     3485       -2     
+ Misses       1975     1974       -1     
Impacted Files Coverage Δ
src/plugins/scene3d/Scene3D.cc 49.56% <0.00%> (-0.07%) ⬇️
src/plugins/minimal_scene/MinimalSceneRhiOpenGL.cc 96.47% <0.00%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b3599...d00cd15. Read the comment docs.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@jennuine
Copy link
Contributor

I believe we can suppress Windows warnings with #pragma warning(disable : 4834) in PointCloud.cc: https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/c4834?view=msvc-170

@chapulina
Copy link
Contributor Author

chapulina commented Mar 17, 2022

I believe we can suppress Windows warnings with #pragma warning(disable : 4834) in PointCloud.cc:

Thanks! I'll open a separate PR for this

@chapulina chapulina merged commit b6215a7 into main Mar 17, 2022
@chapulina chapulina deleted the chapulina/main/rm/bionic branch March 17, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation 🌱 garden Ignition Garden tests Broken or missing tests / testing infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants