Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repo specific issue templates #393

Merged
merged 1 commit into from
May 2, 2022
Merged

Conversation

azeey
Copy link
Contributor

@azeey azeey commented May 2, 2022

Summary

(Related to gazebosim/gz-sim#1461)

Override the org level issue templates in order to make the issue templates more specific to this repo. This is currently just a copy of the files from https://github.com/ignitionrobotics/.github, but we are planning to remove the GUI/Rendering section from the issue templates there.

Note, I had to copy both files in ISSUE_TEMPLATES even though we only need to override bug_report.md because Github will not use the org level defaults if it finds any files in the repo's ISSUE_TEMPLATES directory.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #393 (f8d63b0) into ign-gui6 (eac2fc2) will decrease coverage by 34.97%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           ign-gui6     #393       +/-   ##
=============================================
- Coverage     65.52%   30.54%   -34.98%     
=============================================
  Files            39       41        +2     
  Lines          5157     1748     -3409     
=============================================
- Hits           3379      534     -2845     
+ Misses         1778     1214      -564     
Impacted Files Coverage Δ
include/ignition/gui/Helpers.hh
src/Conversions.cc
include/ignition/gui/MainWindow.hh
src/ign.cc
src/plugins/world_stats/WorldStats.cc
src/plugins/shutdown_button/ShutdownButton.hh
src/plugins/teleop/Teleop.hh
src/plugins/scene3d/Scene3D.cc
src/Plugin.cc
src/plugins/marker_manager/MarkerManager.cc
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eac2fc2...f8d63b0. Read the comment docs.

@azeey azeey merged commit c51789f into ign-gui6 May 2, 2022
@azeey azeey deleted the repo_specific_issue_template branch May 2, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants