Update name and logo on UI, examples and API docs #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <louise@openrobotics.org>
16 tasks
Codecov Report
@@ Coverage Diff @@
## main #398 +/- ##
=======================================
Coverage 30.03% 30.03%
=======================================
Files 43 43
Lines 1888 1888
=======================================
Hits 567 567
Misses 1321 1321
Continue to review full report at Codecov.
|
jennuine
approved these changes
May 19, 2022
There was a problem hiding this comment.
LGTM, found a couple more docs in case you want to change in this PR:
gz-gui/include/gz/gui/Conversions.hh
Line 99 in 8ac8b41
gz-gui/include/gz/gui/Helpers.hh
Lines 94 to 96 in 8ac8b41
- I believe we're deprecating this but I've included it here in case:
gz-gui/src/plugins/scene3d/Scene3D.hh
Line 45 in 8ac8b41
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Thanks! Updated in 96db6c5 |
srmainwaring
added a commit
to srmainwaring/gz-gui
that referenced
this pull request
May 21, 2022
… QML - Adapt the GammaAdjust element from QtGraphicalEffects to work with Metal - Add shaders from Qt - Create a Vulkan supported version of the fragment shader - Generate a shader pack using qsb - Refactor gamma adjustment QML - Move to own QML file and locate with ignition/gui/qml - Move shaders to a private subfolder - Update resources.qrc - Replace import QtGraphicalEffects 1.0 with import "qrc:/qml" Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com> Move header files with git mv (gazebosim#395) Signed-off-by: methylDragon <methylDragon@gmail.com> Create redirection aliases (gazebosim#395) Signed-off-by: methylDragon <methylDragon@gmail.com> Migrate sources in src, test, examples, and include (gazebosim#395) Signed-off-by: methylDragon <methylDragon@gmail.com> Migrate CMake files (gazebosim#395) Signed-off-by: methylDragon <methylDragon@gmail.com> Update name and logo on UI, examples and API docs (gazebosim#398) Signed-off-by: Louise Poubel <louise@openrobotics.org>
srmainwaring
added a commit
to srmainwaring/gz-gui
that referenced
this pull request
Jun 12, 2022
… QML - Adapt the GammaAdjust element from QtGraphicalEffects to work with Metal - Add shaders from Qt - Create a Vulkan supported version of the fragment shader - Generate a shader pack using qsb - Refactor gamma adjustment QML - Move to own QML file and locate with ignition/gui/qml - Move shaders to a private subfolder - Update resources.qrc - Replace import QtGraphicalEffects 1.0 with import "qrc:/qml" Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com> Move header files with git mv (gazebosim#395) Signed-off-by: methylDragon <methylDragon@gmail.com> Create redirection aliases (gazebosim#395) Signed-off-by: methylDragon <methylDragon@gmail.com> Migrate sources in src, test, examples, and include (gazebosim#395) Signed-off-by: methylDragon <methylDragon@gmail.com> Migrate CMake files (gazebosim#395) Signed-off-by: methylDragon <methylDragon@gmail.com> Update name and logo on UI, examples and API docs (gazebosim#398) Signed-off-by: Louise Poubel <louise@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Updated migration guide (as needed)codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸