Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search menu keyboard control #403

Merged
merged 3 commits into from
May 26, 2022
Merged

Search menu keyboard control #403

merged 3 commits into from
May 26, 2022

Conversation

AzulRadio
Copy link
Contributor

New feature

Summary

Now we can navigate the search menu with ↑ ↓ arrow keys and use Enter to select.

demo_search_bar

Test it

Try it!

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label May 23, 2022
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #403 (8cc78c8) into ign-gui6 (5c09688) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           ign-gui6     #403   +/-   ##
=========================================
  Coverage     30.54%   30.54%           
=========================================
  Files            41       41           
  Lines          1748     1748           
=========================================
  Hits            534      534           
  Misses         1214     1214           
Impacted Files Coverage Δ
include/ignition/gui/qrc_resources.cpp 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c09688...8cc78c8. Read the comment docs.

@chapulina chapulina added the OOBE 📦✨ Out-of-box experience label May 23, 2022
Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting minor change but otherwise works great!

include/ignition/gui/qml/PluginMenu.qml Outdated Show resolved Hide resolved
Signed-off-by: youhy <haoyuan2019@outlook.com>
@jennuine jennuine merged commit 5d5755c into ign-gui6 May 26, 2022
@jennuine jennuine deleted the azulradio/search_menu_key branch May 26, 2022 15:38
AzulRadio added a commit that referenced this pull request May 27, 2022
Signed-off-by: youhy <haoyuan2019@outlook.com>
chapulina pushed a commit that referenced this pull request May 27, 2022
Signed-off-by: youhy <haoyuan2019@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress OOBE 📦✨ Out-of-box experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants