-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shortcut to search and auto highlight search bar #405
Conversation
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
Codecov Report
@@ Coverage Diff @@
## ign-gui6 #405 +/- ##
=========================================
Coverage 30.54% 30.54%
=========================================
Files 41 41
Lines 1748 1748
=========================================
Hits 534 534
Misses 1214 1214
Continue to review full report at Codecov.
|
Signed-off-by: youhy <haoyuan2019@outlook.com>
* search bar text highlight * add search bar shortcut "/" Signed-off-by: youhy <haoyuan2019@outlook.com> Co-authored-by: Jenn Nguyen <jenn@openrobotics.org>
* search bar text highlight * add search bar shortcut "/" Signed-off-by: youhy <haoyuan2019@outlook.com> Co-authored-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: youhy haoyuan2019@outlook.com
New feature(s)
Summary
There are 2 features added in this PR. Both of them are small and are about the search bar/menu so I combine them into one PR.
Feature 1. When we close the search bar for adding plugins, the text in it will be preserved. If we want to add another plugin, we need to delete the first one. That's a little annoying. Now after adding a plugin, text in the search bar will be auto highlighted so the search bar can be cleared easier.
No highlight if no plugin is added.
Feature 2. Press
/
to open the plugin search barTest it
Try it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.