Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign -> gz CLI Migration : gz-gui #417

Merged
merged 3 commits into from
Jun 23, 2022
Merged

ign -> gz CLI Migration : gz-gui #417

merged 3 commits into from
Jun 23, 2022

Conversation

methylDragon
Copy link
Contributor

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 12, 2022
@methylDragon methylDragon marked this pull request as ready for review June 13, 2022 05:37
@methylDragon
Copy link
Contributor Author

CI failure needs the merge of gz-tools so the gz executable is available

@methylDragon methylDragon added the needs upstream release Blocked by a release of an upstream library label Jun 13, 2022
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo label Jun 13, 2022
@methylDragon methylDragon force-pushed the cli_migration branch 2 times, most recently from 08b1f5e to b42f6e0 Compare June 18, 2022 06:16
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh include/ignition/gui/ign.hh is installed, so we shouldn't move it. I think it's ok to leave it as it is, because it's already deprecated inside the ignition folder, and the new include/gz/gui/gz.hh header is already correct.

Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Copy link
Contributor Author

Ahh include/ignition/gui/ign.hh is installed, so we shouldn't move it. I think it's ok to leave it as it is, because it's already deprecated inside the ignition folder, and the new include/gz/gui/gz.hh header is already correct.

Fixed! Move no longer occurs in a2489b3

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #417 (b7165a9) into main (9afab1e) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head b7165a9 differs from pull request most recent head e6d8f1f. Consider uploading reports for the commit e6d8f1f to get more accurate results

@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
- Coverage   64.15%   64.12%   -0.04%     
==========================================
  Files          45       45              
  Lines        5527     5527              
==========================================
- Hits         3546     3544       -2     
- Misses       1981     1983       +2     
Impacted Files Coverage Δ
src/gz.cc 42.85% <ø> (ø)
...interactive_view_control/InteractiveViewControl.hh 100.00% <ø> (ø)
src/plugins/scene3d/Scene3D.cc 49.56% <0.00%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9afab1e...e6d8f1f. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UNIT_gz_TEST passes on Linux and macOS!

@chapulina chapulina merged commit ed3ea29 into main Jun 23, 2022
@chapulina chapulina deleted the cli_migration branch June 23, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo needs upstream release Blocked by a release of an upstream library
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants