-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ign -> gz CLI Migration : gz-gui #417
Conversation
CI failure needs the merge of |
08b1f5e
to
b42f6e0
Compare
@osrf-jenkins run tests please! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh include/ignition/gui/ign.hh
is installed, so we shouldn't move it. I think it's ok to leave it as it is, because it's already deprecated inside the ignition
folder, and the new include/gz/gui/gz.hh
header is already correct.
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
b42f6e0
to
34de943
Compare
Fixed! Move no longer occurs in a2489b3 |
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## main #417 +/- ##
==========================================
- Coverage 64.15% 64.12% -0.04%
==========================================
Files 45 45
Lines 5527 5527
==========================================
- Hits 3546 3544 -2
- Misses 1981 1983 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UNIT_gz_TEST
passes on Linux and macOS!
See: gazebo-tooling/release-tools#739