-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add common widget for vector3 #427
Conversation
Signed-off-by: youhy <haoyuan2019@outlook.com>
Codecov Report
@@ Coverage Diff @@
## ign-gui3 #427 +/- ##
===========================================
Coverage ? 66.42%
===========================================
Files ? 29
Lines ? 3291
Branches ? 0
===========================================
Hits ? 2186
Misses ? 1105
Partials ? 0 Continue to review full report at Codecov.
|
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: youhy <haoyuan2019@outlook.com>
Item { | ||
id: gzVectorRoot | ||
|
||
// Readn-only / write |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Readn-only / write | |
// Read-only / write |
property string zName: "Z" | ||
|
||
// Units, defaults to meters. | ||
// Set to "" to omit the parentheses. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Set to "" to omit the parentheses. | |
// Set to "" to omit the units & parentheses. |
height: gzVectorContent.height | ||
|
||
// Maximum spinbox value | ||
property double spinMax: Number.MAX_VALUE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be moved out of the private variables section since users can overwrite
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: youhy haoyuan2019@outlook.com
New feature
Summary
Add common widget for vector3
Test it
Use the following test QML to test:
Then use
to test
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.