Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ign-gui2 ➡️ ign-gui3 #444

Merged
merged 5 commits into from
Jul 28, 2022
Merged

Merge ign-gui2 ➡️ ign-gui3 #444

merged 5 commits into from
Jul 28, 2022

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-gui2 ➡️ ign-gui3

Branch comparision: ign-gui3...ign-gui2

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

nkoenig and others added 4 commits July 22, 2022 21:52
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>

Co-authored-by: Nate Koenig <nate@openrobotics.org>
Co-authored-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from jennuine as a code owner July 28, 2022 16:20
@chapulina chapulina requested a review from nkoenig July 28, 2022 16:20
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jul 28, 2022
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #444 (04814f9) into ign-gui3 (1610733) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           ign-gui3     #444   +/-   ##
=========================================
  Coverage     66.88%   66.88%           
=========================================
  Files            29       29           
  Lines          3310     3310           
=========================================
  Hits           2214     2214           
  Misses         1096     1096           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1610733...04814f9. Read the comment docs.

CMakeLists.txt Outdated Show resolved Hide resolved
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@chapulina chapulina enabled auto-merge July 28, 2022 19:47
@chapulina chapulina merged commit a03a876 into ign-gui3 Jul 28, 2022
@chapulina chapulina deleted the chapulina/2_to_3 branch July 28, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants