Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed topic echo test #448

Merged
merged 3 commits into from
Aug 2, 2022
Merged

Fixed topic echo test #448

merged 3 commits into from
Aug 2, 2022

Conversation

jennuine
Copy link
Contributor

🦟 Bug fix

Part of gazebosim/gz-sim#1575

Summary

Fixed the TopicEcho_TEST.

Checklist

  • Signed all commits for DCO
  • Added tests
  • [ ] Updated documentation (as needed)
  • [ ] Updated migration guide (as needed)
  • [ ] Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
@jennuine jennuine added tests Broken or missing tests / testing infra QA Quality assurance. labels Jul 30, 2022
@jennuine jennuine requested a review from chapulina as a code owner July 30, 2022 00:23
@jennuine jennuine self-assigned this Jul 30, 2022
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM if it passes CI.

@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jul 30, 2022
@codecov
Copy link

codecov bot commented Jul 30, 2022

Codecov Report

Merging #448 (a1cfeae) into ign-gui3 (04814f9) will increase coverage by 1.08%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           ign-gui3     #448      +/-   ##
============================================
+ Coverage     66.88%   67.97%   +1.08%     
============================================
  Files            29       29              
  Lines          3310     3310              
============================================
+ Hits           2214     2250      +36     
+ Misses         1096     1060      -36     
Impacted Files Coverage Δ
src/plugins/topic_echo/TopicEcho.cc 91.52% <ø> (+61.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

src/plugins/topic_echo/TopicEcho_TEST.cc Outdated Show resolved Hide resolved
src/plugins/topic_echo/TopicEcho_TEST.cc Outdated Show resolved Hide resolved
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing that test back!

@chapulina chapulina merged commit b543beb into ign-gui3 Aug 2, 2022
@chapulina chapulina deleted the jennuine/echo_test branch August 2, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel QA Quality assurance. tests Broken or missing tests / testing infra
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants