-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed topic echo test #448
Conversation
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM if it passes CI.
Codecov Report
@@ Coverage Diff @@
## ign-gui3 #448 +/- ##
============================================
+ Coverage 66.88% 67.97% +1.08%
============================================
Files 29 29
Lines 3310 3310
============================================
+ Hits 2214 2250 +36
+ Misses 1096 1060 -36
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing that test back!
🦟 Bug fix
Part of gazebosim/gz-sim#1575
Summary
Fixed the
TopicEcho_TEST
.Checklist
[ ] Updated documentation (as needed)[ ] Updated migration guide (as needed)[ ] Consider updating Python bindings (if the library has them)codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.