Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog read attribute: don't create a file #450

Merged
merged 3 commits into from
Aug 2, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Aug 2, 2022

🦟 Bug fix

Summary

The ReadConfigAttribute function was doing more than reading, it was also creating a file if it didn't exist, which wasn't very convenient. Since this is a brand-new function, I think it's ok to change its behavior. I documented it on the migration guide just in case.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the OOBE 📦✨ Out-of-box experience label Aug 2, 2022
@chapulina chapulina requested a review from mayman99 August 2, 2022 02:51
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 2, 2022
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina marked this pull request as ready for review August 2, 2022 16:01
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #450 (638c9f1) into ign-gui3 (b543beb) will decrease coverage by 0.16%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##           ign-gui3     #450      +/-   ##
============================================
- Coverage     67.97%   67.81%   -0.17%     
============================================
  Files            29       29              
  Lines          3310     3281      -29     
============================================
- Hits           2250     2225      -25     
+ Misses         1060     1056       -4     
Impacted Files Coverage Δ
src/Dialog.cc 73.01% <80.00%> (-4.16%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Contributor

@mayman99 mayman99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chapulina chapulina merged commit 9f5c9c2 into ign-gui3 Aug 2, 2022
@chapulina chapulina deleted the chapulina/3/read_dialog branch August 2, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel OOBE 📦✨ Out-of-box experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants