Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz : Remove redundant namespace references #460

Merged
merged 1 commit into from
Aug 16, 2022
Merged

ign -> gz : Remove redundant namespace references #460

merged 1 commit into from
Aug 16, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon mentioned this pull request Aug 9, 2022
Open
@codecov
Copy link

codecov bot commented Aug 9, 2022 •
edited
Loading

Codecov Report

Merging #460 (f4dddd5) into ign-gui3 (212004b) will not change coverage.
The diff coverage is 90.90%.

❗ Current head f4dddd5 differs from pull request most recent head f867a26. Consider uploading reports for the commit f867a26 to get more accurate results

@@            Coverage Diff            @@
##           ign-gui3     #460   +/-   ##
=========================================
  Coverage     69.81%   69.81%           
=========================================
  Files            29       29           
  Lines          3273     3273           
=========================================
  Hits           2285     2285           
  Misses          988      988
Impacted Files Coverage Δ
src/plugins/key_publisher/KeyPublisher.cc 56.52% <80.00%> (ø)
src/Application.cc 87.50% <100.00%> (ø)
src/MainWindow.cc 95.80% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 9, 2022
@methylDragon methylDragon force-pushed the namespace_cleanup branch 4 times, most recently from 778fc38 to 84aff5f Compare August 9, 2022 19:37
@chapulina
Copy link
Contributor

There are some new test failures. I haven't looked closely to see what could have caused them.

@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo label Aug 10, 2022
@methylDragon
Remove redundant namespace references
f867a26 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Copy link
Contributor Author

methylDragon commented Aug 12, 2022 •
edited
Loading

I think I fixed it with https://github.com/gazebosim/gz-gui/compare/54337fb666c8590deb753ab08ede52c2139cb54d..f867a260fde4c0a0cbc393cfabad01e801d26e39#diff-6d22bd4a878f58dee5cd6717ece1c2343d7deecac76701b20b34596b25b82e50L102 , but we need to wait on CI to be sure since I've been testing on Jammy

I don't know why it fails otherwise, but.. 🤷

@methylDragon
Copy link
Contributor Author

All required tests now pass

@chapulina chapulina merged commit 8bc5bed into ign-gui3 Aug 16, 2022
@chapulina chapulina deleted the namespace_cleanup branch August 16, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@jennuine jennuine Awaiting requested review from jennuine jennuine is a code owner

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel ign to gz Renaming Ignition to Gazebo
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina