-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace color and pose for GridConfig with GzColor and GzPose #463
Conversation
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
Codecov Report
@@ Coverage Diff @@
## ign-gui6 #463 +/- ##
============================================
+ Coverage 67.97% 68.00% +0.03%
============================================
Files 39 39
Lines 5239 5239
============================================
+ Hits 3561 3563 +2
+ Misses 1678 1676 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy haoyuan2019@outlook.com
New feature
Summary
As title. The behavior should be exactly the same as before.
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.