Added Reset button to world_control #476

ahcorde · 2022-08-24T16:20:22Z

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

Added a reset button to the world Control plugin

Test

gz sim rolling_shapes.sdf

Checklist

Signed all commits for DCO
Added tests
Added example and/or tutorial
Updated documentation (as needed)
Updated migration guide (as needed)
Consider updating Python bindings (if the library has them)
codecheck passed (See contributing)
All tests passed (See test coverage)
While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>

mjcarroll · 2022-08-24T18:08:30Z

A super pedantic nit: Can we get a reset icon? :)

jennuine

Can we get a reset icon?

+1, the square is misleading. At a glace, it looks like a stop button.

Also, since we are feature frozen, this will need to come in a minor release

src/plugins/world_control/WorldControl.cc

jennuine · 2022-08-24T23:29:02Z

src/plugins/world_control/WorldControl.qml

+  RoundButton {
+    id: stopButton
+    objectName: "stopButton"
+    visible: showReset


Should reset only be visible if the sim is paused?

you might want to reset when the simulation is running

jennuine · 2022-08-24T23:32:14Z

src/plugins/world_control/WorldControl.qml

+  /**
+   * Reset
+   */
+  RoundButton {


Can we add a hovered tooltip that states what reset does?

ahcorde · 2022-08-25T15:35:09Z

A super pedantic nit: Can we get a reset icon? :)

@mjcarroll I was thinking about adding an icon but I was trying to follow the same style which is an unicode geometric shape https://en.wikipedia.org/wiki/List_of_Unicode_characters. I'm open to suggestion.

Anyhow the way that I implemented the reset is more like a stop (reset + pause)

jennuine · 2022-08-25T15:58:20Z

How about using the same icon as refresh in ImageDisplay?

gz-gui/src/plugins/image_display/ImageDisplay.qml

Line 63 in a60cb7d

text: "\u21bb"

ahcorde · 2022-08-25T16:03:39Z

How about using the same icon as refresh in ImageDisplay?

gz-gui/src/plugins/image_display/ImageDisplay.qml

Line 63 in a60cb7d

text: "\u21bb"

nice! thank you @jennuine

jennuine · 2022-08-25T16:09:34Z

Users may accidentally click this icon so another nice feature would be to have a confirmation dialog before resetting similar to #225 (with the ability to disable the dialog through the config)

chapulina

It would be nice to also add the Ctrl+R shortcut, and then we can close

Reset models and worlds similarly to Ctrl + R in Gazebo Classic gz-sim#203

scpeters · 2022-08-29T23:43:47Z

@osrf-jenkins run tests please

Signed-off-by: ahcorde <ahcorde@gmail.com>

ahcorde · 2022-08-30T10:41:20Z

It would be nice to also add the Ctrl+R shortcut, and then we can close

gazebosim/gz-sim#203

dbd8c74

Signed-off-by: ahcorde <ahcorde@gmail.com>

codecov · 2022-08-30T10:57:55Z

Codecov Report

Merging #476 (ec25c37) into gz-gui7 (17bd485) will decrease coverage by 0.10%.
The diff coverage is 20.00%.

❗ Current head ec25c37 differs from pull request most recent head c204bbf. Consider uploading reports for the commit c204bbf to get more accurate results

@@             Coverage Diff             @@
##           gz-gui7     #476      +/-   ##
===========================================
- Coverage    69.13%   69.03%   -0.11%     
===========================================
  Files           44       44              
  Lines         4821     4831      +10     
===========================================
+ Hits          3333     3335       +2     
- Misses        1488     1496       +8

Impacted Files	Coverage Δ
src/plugins/world_control/WorldControl.cc	`72.60% <0.00%> (-4.21%)`	⬇️
...plugins/world_control/WorldControlEventListener.hh	`100.00% <ø> (ø)`
...plugins/world_control/WorldControlEventListener.cc	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ahcorde · 2022-11-08T23:36:14Z

friendly ping @jennuine @mjcarroll

jennuine

nit: can we leave the play/step buttons how they were and add the reset button to the right of the step button? And have the reset button be the same size as step?

…rol/reset

ahcorde · 2022-11-11T11:47:11Z

@jennuine

what do you think about this ?

Signed-off-by: ahcorde <ahcorde@gmail.com>

jennuine · 2022-11-11T18:22:54Z

@jennuine

what do you think about this ?

Looks great, thanks! How do you and @mjcarroll feel about the reset button being to the right of the step button? Reasons being:

Users are less likely to accidentally hit reset when attempting to pause (I know this is less likely but I can still see it happening)
It keeps the old/previous layout the same while adding the new feature

ahcorde · 2022-11-11T18:52:27Z

@jennuine
what do you think about this ?

Looks great, thanks! How do you and @mjcarroll feel about the reset button being to the right of the step button? Reasons being:

Users are less likely to accidentally hit reset when attempting to pause (I know this is less likely but I can still see it happening)

It keeps the old/previous layout the same while adding the new feature

Anyhow when you click in the reset button a Dialog will appers to ensure that you want to reset the simulation. Not dangerous at all.

ahcorde · 2022-11-14T13:00:54Z

@jennuine
what do you think about this ?

Looks great, thanks! How do you and @mjcarroll feel about the reset button being to the right of the step button? Reasons being:

Users are less likely to accidentally hit reset when attempting to pause (I know this is less likely but I can still see it happening)

It keeps the old/previous layout the same while adding the new feature

Anyhow when you click in the reset button a Dialog will appers to ensure that you want to reset the simulation. Not dangerous at all.

changing layout doesn't seem to be working, the step botton uses a mouseclick area, it's tricky to change it

mjcarroll · 2022-11-14T13:07:39Z

the step botton uses a mouseclick area, it's tricky to change it

If it is too difficult to fix, I think that the dialog confirmation is sufficiently safe.

ahcorde · 2022-11-14T18:15:42Z

@osrf-jenkins run tests please!

ahcorde · 2022-11-14T18:31:08Z

@osrf-jenkins run tests please!

ahcorde · 2022-11-15T09:18:56Z

@osrf-jenkins run tests please!

Added Reset button to world_control

5fd0b6d

Signed-off-by: ahcorde <ahcorde@gmail.com>

ahcorde requested review from chapulina and jennuine as code owners August 24, 2022 16:20

github-actions bot added the 🌱 garden Ignition Garden label Aug 24, 2022

jennuine reviewed Aug 24, 2022

View reviewed changes

chapulina added the enhancement New feature or request label Aug 26, 2022

chapulina reviewed Aug 26, 2022

View reviewed changes

Added dialog and Key control

dbd8c74

Signed-off-by: ahcorde <ahcorde@gmail.com>

Added hovered tooltip

639643d

Signed-off-by: ahcorde <ahcorde@gmail.com>

ahcorde added 2 commits September 9, 2022 13:05

Merge branch 'gz-gui7' into ahcorde/world_control/reset

0eb2ed0

Merge branch 'gz-gui7' into ahcorde/world_control/reset

9da1df8

ahcorde requested a review from jennuine October 10, 2022 11:27

ahcorde self-assigned this Oct 10, 2022

Merge branch 'gz-gui7' into ahcorde/world_control/reset

2a760e4

jennuine reviewed Nov 9, 2022

View reviewed changes

Merge remote-tracking branch 'origin/gz-gui7' into ahcorde/world_cont…

27dc936

…rol/reset

Fix button size

c204bbf

Signed-off-by: ahcorde <ahcorde@gmail.com>

mjcarroll approved these changes Nov 11, 2022

View reviewed changes

jennuine approved these changes Nov 14, 2022

View reviewed changes

ahcorde enabled auto-merge (squash) November 14, 2022 18:30

mjcarroll disabled auto-merge November 15, 2022 13:15

mjcarroll merged commit 780cb23 into gz-gui7 Nov 15, 2022

mjcarroll deleted the ahcorde/world_control/reset branch November 15, 2022 13:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Reset button to world_control #476

Added Reset button to world_control #476

ahcorde commented Aug 24, 2022

mjcarroll commented Aug 24, 2022

jennuine left a comment •

edited

Loading

jennuine Aug 24, 2022

ahcorde Aug 30, 2022

jennuine Aug 24, 2022

ahcorde Aug 30, 2022

ahcorde commented Aug 25, 2022

jennuine commented Aug 25, 2022

ahcorde commented Aug 25, 2022

jennuine commented Aug 25, 2022

chapulina left a comment

scpeters commented Aug 29, 2022

ahcorde commented Aug 30, 2022

codecov bot commented Aug 30, 2022 •

edited

Loading

ahcorde commented Nov 8, 2022

jennuine left a comment

ahcorde commented Nov 11, 2022

jennuine commented Nov 11, 2022 •

edited

Loading

ahcorde commented Nov 11, 2022

ahcorde commented Nov 14, 2022

mjcarroll commented Nov 14, 2022

ahcorde commented Nov 14, 2022

ahcorde commented Nov 14, 2022

ahcorde commented Nov 15, 2022

Added Reset button to world_control #476

Added Reset button to world_control #476

Conversation

ahcorde commented Aug 24, 2022

🎉 New feature

Summary

Test

Checklist

mjcarroll commented Aug 24, 2022

jennuine left a comment • edited Loading

Choose a reason for hiding this comment

jennuine Aug 24, 2022

Choose a reason for hiding this comment

ahcorde Aug 30, 2022

Choose a reason for hiding this comment

jennuine Aug 24, 2022

Choose a reason for hiding this comment

ahcorde Aug 30, 2022

Choose a reason for hiding this comment

ahcorde commented Aug 25, 2022

jennuine commented Aug 25, 2022

ahcorde commented Aug 25, 2022

jennuine commented Aug 25, 2022

chapulina left a comment

Choose a reason for hiding this comment

scpeters commented Aug 29, 2022

ahcorde commented Aug 30, 2022

codecov bot commented Aug 30, 2022 • edited Loading

Codecov Report

ahcorde commented Nov 8, 2022

jennuine left a comment

Choose a reason for hiding this comment

ahcorde commented Nov 11, 2022

jennuine commented Nov 11, 2022 • edited Loading

ahcorde commented Nov 11, 2022

ahcorde commented Nov 14, 2022

mjcarroll commented Nov 14, 2022

ahcorde commented Nov 14, 2022

ahcorde commented Nov 14, 2022

ahcorde commented Nov 15, 2022

jennuine left a comment •

edited

Loading

codecov bot commented Aug 30, 2022 •

edited

Loading

jennuine commented Nov 11, 2022 •

edited

Loading