Update cmd/CMakeLists to conform with all other gz libraries (#478) #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These tests are failing: |
…im#478) This fixes the library path obtained by cmdgui.rb such that it points to the .so file contained in the non-dev debian pack Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## gz-gui7 #480 +/- ##
========================================
Coverage 67.82% 67.82%
========================================
Files 44 44
Lines 4826 4826
========================================
Hits 3273 3273
Misses 1553 1553
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jennuine
reviewed
Aug 31, 2022
Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Jenn Nguyen <jenn@openrobotics.org>
jennuine
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Cherry-pick #478 from ign-gui3 since merging forward would introduce new features during feature freeze. This is needed to make
gz guiwork properly. It could come in a minor release sincegz guiis not a commonly used tool.Note to maintainers: Remember to use Rebase-and-merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.