Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused headers #490

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Remove unused headers #490

merged 1 commit into from
Sep 14, 2022

Conversation

jennuine
Copy link
Contributor

🦟 Bug fix

Summary

Remove unused headers, which were causing the abi checker to fail (first detected in #486)

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
@jennuine jennuine added the bug Something isn't working label Sep 14, 2022
@jennuine jennuine self-assigned this Sep 14, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 14, 2022
@methylDragon
Copy link
Contributor

This PR needs #486 to pass
I say we just force a merge 😬, since we'll need a forced merge anyway to get the ABI checker to be happy.

Help! @scpeters ?

@scpeters
Copy link
Member

@osrf-jenkins run tests please

@jennuine
Copy link
Contributor Author

@scpeters #486 fixes INTEGRATION_ExamplesBuild_TEST but the abi checker is failing. This PR should fix abi but (from my understanding) not until after it's merged. I do not have privileges to override the merge

@scpeters scpeters merged commit 7da9972 into gz-gui7 Sep 14, 2022
@scpeters scpeters deleted the jennuine/remove_headers branch September 14, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants