Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump msgs and transport version in Harmonic #517

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Feb 11, 2023

🎉 New feature

Summary

Bumping to use the new msgs and transport versions in Harmonic, msgs10 and transport13

Part of gazebo-tooling/release-tools#878

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Merging #517 (5371f05) into main (91ed341) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #517   +/-   ##
=======================================
  Coverage   68.30%   68.30%           
=======================================
  Files          45       45           
  Lines        5038     5038           
=======================================
  Hits         3441     3441           
  Misses       1597     1597           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@iche033
Copy link
Contributor Author

iche033 commented Feb 18, 2023

@osrf-jenkins run tests please

@iche033 iche033 marked this pull request as ready for review February 18, 2023 04:01
@iche033
Copy link
Contributor Author

iche033 commented Feb 18, 2023

CIs look good now. This PR is ready for review

@iche033 iche033 merged commit 94d1586 into main Feb 21, 2023
@iche033 iche033 deleted the bump_msgs_transport branch February 21, 2023 18:40
@iche033 iche033 added the 🎵 harmonic Gazebo Harmonic label Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants