Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6 ➡️ 7 #524

Merged
merged 4 commits into from
Mar 23, 2023
Merged

6 ➡️ 7 #524

merged 4 commits into from
Mar 23, 2023

Conversation

jennuine
Copy link
Contributor

➡️ Forward port

Port ign-gui6 to gz-gui7

Branch comparison: gz-gui7...ign-gui6

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

iche033 and others added 3 commits February 14, 2023 10:56
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
@jennuine jennuine self-assigned this Mar 17, 2023
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Mar 17, 2023
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #524 (8f415f3) into gz-gui7 (adaa4a9) will decrease coverage by 1.02%.
The diff coverage is n/a.

❗ Current head 8f415f3 differs from pull request most recent head 0d22cf3. Consider uploading reports for the commit 0d22cf3 to get more accurate results

@@             Coverage Diff             @@
##           gz-gui7     #524      +/-   ##
===========================================
- Coverage    69.11%   68.10%   -1.02%     
===========================================
  Files           44       39       -5     
  Lines         4919     5327     +408     
===========================================
+ Hits          3400     3628     +228     
- Misses        1519     1699     +180     

see 36 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jennuine jennuine requested a review from iche033 March 17, 2023 00:46
@iche033
Copy link
Contributor

iche033 commented Mar 17, 2023

I think there is an issue with the new homebrew machine, retriggered a new build

@jennuine jennuine merged commit b90acee into gz-gui7 Mar 23, 2023
@jennuine jennuine deleted the jennuine/6_to_7 branch March 23, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants