Apply low-pass filter to RTF display #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
|
@iche033 I've made the filter less aggressive than what I had gazebosim/gz-sim#1942 so that it is responsive to changes like the image display being removed while still providing a stable RTF reading. |
8 tasks
Codecov Report
@@ Coverage Diff @@
## gz-gui7 #529 +/- ##
===========================================
+ Coverage 69.13% 69.19% +0.05%
===========================================
Files 44 44
Lines 4921 4937 +16
===========================================
+ Hits 3402 3416 +14
- Misses 1519 1521 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
iche033
approved these changes
Apr 7, 2023
| @@ -57,6 +57,9 @@ namespace plugins | |||
|
|
|||
| /// \brief Holds iterations | |||
| public: QString iterations; | |||
|
|
|||
| public: std::optional<double> simTimeDelayed; | |||
| public: std::optional<double> realTimeDelayed; | |||
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Follow-up from gazebosim/gz-sim#1942
Summary
This adds a more aggressive low-pass filter than what was in gz-sim such that the RTF display is more stable and reflects the RTF of a longer window of time.
Test it
Run
gz sim camera_sensor.sdf. The RTF will display is much more stable than before. After a while, remove the image display and watch the RTF increase.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.