Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Teleop_TEST on macOS #530

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Apr 7, 2023

🦟 Bug fix

Relates to #503

Summary

The test started segfaulting on macOS when qt5 was updated to 5.15.7. The segfault doesn't occur on 5.15.6

You can try by installing qt@5 5.15.6

curl https://raw.githubusercontent.com/Homebrew/homebrew-core/4b3d3887ff69f917f9d3dc76e80c307b665d7ac0/Formula/qt%405.rb -o qt@5.rb
brew reinstall ./qt@5.rb

and running UNIT_Teleop_TEST

This PR disables the test since it's not immediately clear how to fix the crash.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from jennuine as a code owner April 7, 2023 23:21
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 7, 2023
@azeey azeey merged commit bf42b84 into gazebosim:gz-gui7 Apr 10, 2023
@azeey azeey deleted the disable_telop_test_macos branch April 10, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants