Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue in TopicViewer #566

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Fix issue in TopicViewer #566

merged 1 commit into from
Aug 25, 2023

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Aug 24, 2023

🦟 Bug fix

See #430

Summary

This patch fixes a crash running the TopicViewer plugin. The code was assuming that all topics reported after calling TopicList() have publishers. This is no longer the case as we can also report subscribers.

See #430 to reproduce the issue/fix with the Gazebo Topic Viewer plugin.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero caguero requested a review from jennuine as a code owner August 24, 2023 22:30
@caguero caguero requested a review from iche033 August 24, 2023 22:30
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #566 (6fdeb04) into main (974957f) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head 6fdeb04 differs from pull request most recent head 95c5b1f. Consider uploading reports for the commit 95c5b1f to get more accurate results

@@            Coverage Diff             @@
##             main     #566      +/-   ##
==========================================
- Coverage   68.05%   68.03%   -0.03%     
==========================================
  Files          38       38              
  Lines        5394     5396       +2     
==========================================
  Hits         3671     3671              
- Misses       1723     1725       +2     
Files Changed Coverage Δ
src/plugins/topic_viewer/TopicViewer.cc 80.64% <0.00%> (-1.06%) ⬇️

@azeey azeey added the beta Targeting beta release of upcoming collection label Aug 25, 2023
@caguero caguero merged commit c7c3011 into main Aug 25, 2023
5 of 7 checks passed
@caguero caguero deleted the caguero/topic_viewer_issue branch August 25, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants