Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugins namespace #571

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Add plugins namespace #571

merged 2 commits into from
Sep 14, 2023

Conversation

mabelzhang
Copy link
Contributor

🦟 Bug fix

Add namespace so gz::gui::plugins can be used as a \ref link in gz-sim Doxygen tutorials.

Summary

Per gazebosim/gz-sim#2107 (comment)

Braces same line or breakline - I followed the format here
https://github.com/gazebosim/gz-sim/blob/9d79b629c9e0fed1c8635e30f06b2c61462f32d8/include/gz/sim/System.hh#L40

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #571 (6357740) into gz-gui8 (e115d56) will not change coverage.
The diff coverage is n/a.

❗ Current head 6357740 differs from pull request most recent head 91f9750. Consider uploading reports for the commit 91f9750 to get more accurate results

@@           Coverage Diff            @@
##           gz-gui8     #571   +/-   ##
========================================
  Coverage    68.10%   68.10%           
========================================
  Files           38       38           
  Lines         5367     5367           
========================================
  Hits          3655     3655           
  Misses        1712     1712           
Files Changed Coverage Δ
include/gz/gui/Plugin.hh 100.00% <ø> (ø)

@azeey azeey added the beta Targeting beta release of upcoming collection label Sep 14, 2023
@mabelzhang
Copy link
Contributor Author

ABI check is failing 🤔 But I'm not seeing anything obvious on Jenkins. There isn't an ABI report...?

@azeey
Copy link
Contributor

azeey commented Sep 14, 2023

ABI check is failing 🤔 But I'm not seeing anything obvious on Jenkins. There isn't an ABI report...?

ABI checker is not working on Harmonic yet. It can be ignored for now.

@azeey azeey merged commit c01d327 into gz-gui8 Sep 14, 2023
6 checks passed
@azeey azeey deleted the mabelzhang/add_plugins_namespace branch September 14, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants